Set SmartHint.IsContentNullOrEmpty on initial load #3915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks good. Would you mind adding a UI test for this case as well? |
|
I added a UI test for this. |
|
Hello, I think your modification should be placed in the action section. Could you please have this bug fixed by me? I want to join some open-source communities to learn from them. |
DoLovya
pushed a commit
to DoLovya/MaterialDesignInXamlToolkit
that referenced
this pull request
Sep 12, 2025
|
I reopened this so the tests run on CI once more. So far I couldn't reproduce the failing test ( |
Keboo
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3914
As far as I can tell, the root cause of this issue is that the
SmartHint.IsContentNullOrEmptyis not updated when the visibility changes, and therefore set tofalse(even though it should betrue).Setting the
IsContentNullOrEmptyinitially (in theRefreshStatemethod) fixes this issue.